Re: sql_drop Event Triggerg

Alvaro Herrera <alvherre@2ndquadrant.com>

From: Alvaro Herrera <alvherre@2ndquadrant.com>

To: Tom Lane <tgl@sss.pgh.pa.us>

Cc: Robert Haas <robertmhaas@gmail.com>, Dimitri Fontaine <dimitri@2ndquadrant.fr>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>

Date: 2013-03-27T15:54:37Z

Lists: pgsql-hackers

Attachments

dropped_objects.11.patch (text/x-diff) patch

Alvaro Herrera escribió:
> Alvaro Herrera escribió:
> 
> > However, I think previous discussions have conflated many different
> > things, and we've been slowly fixing them one by one; so perhaps at this
> > point it does make sense to have a new object-drop event.  Let's discuss
> > it -- we would define it as taking place just before ddl_command_end,
> > and firing any time a command (with matching tag?) has called
> > performDeletion or performMultipleDeletions.  Does that sound okay?

> [1mdiff --git a/doc/src/sgml/event-trigger.sgml b/doc/src/sgml/event-trigger.sgml[m
> [1mindex 71241c8..492a4ed 100644[m
> [1m--- a/doc/src/sgml/event-trigger.sgml[m
> [1m+++ b/doc/src/sgml/event-trigger.sgml[m

Uh, seems I posted the --color version of the patch last night.  Easy
mistake to make.  Here's a readable version (context diff, even), with a
couple of bugs fixed that I noticed while writing the final docs.  Some
random minor cleanup too.  I also took the opportunity to refactor some
common code in the invoking sequence of existing events; there was way
too much unnecessary duplication there.

This horse is about to become corpse; last chance for beating it up.

-- 
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services