Re: sql_drop Event Triggerg
Alvaro Herrera <alvherre@2ndquadrant.com>
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Dimitri Fontaine <dimitri@2ndquadrant.fr>, Tom Lane <tgl@sss.pgh.pa.us>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2013-03-26T19:49:59Z
Lists: pgsql-hackers
Robert Haas escribió: > On Tue, Mar 26, 2013 at 3:02 PM, Alvaro Herrera > <alvherre@2ndquadrant.com> wrote: > > Now there *is* one rather big performance problem in this patch, which > > is that it turns on collection of object dropped data regardless of > > there being event triggers that use the info at all. That's a serious > > drawback and we're going to get complaints about it. So we need to do > > something to fix that. > > Really? Who is going to care about that? Surely that overhead is > quite trivial. I don't think it is, because it involves syscache lookups for each object being dropped, many extra pallocs, etc. Surely that's many times bigger than the PG_TRY overhead you were worried about. -- Álvaro Herrera http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services