Horton

Re: Proposal for Allow postgresql.conf values to be changed via SQL [review]

Andres Freund <andres@2ndquadrant.com>

View thread View on postgr.es
From: Andres Freund <andres@2ndquadrant.com>
To: Amit Kapila <amit.kapila@huawei.com>
Cc: 'Greg Stark' <stark@mit.edu>, 'Greg Smith' <greg@2ndquadrant.com>, 'Boszormenyi Zoltan' <zb@cybertec.at>, pgsql-hackers@postgresql.org
Date: 2013-03-13T12:39:41Z
Lists: pgsql-hackers 
On 2013-03-12 10:46:53 +0530, Amit Kapila wrote:
> Do you mean to say that because some variables can only be set after restart
> can lead to 
> inconsistency, or is it because of asynchronous nature of pg_reload_conf()?

As long as SET PERSISTENT cannot be executed inside a transaction - or
only takes effect after its end - there doesn't seem to be any problem
executing ProcessConfigFile() directly.

The reason its not executed directly is that it is normally called
during query execution and it wouldn't be nice changing stuff after half
of a query has been processed.

Greetings,

Andres Freund

-- 
 Andres Freund	                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services