Re: sql_drop Event Trigger
Alvaro Herrera <alvherre@2ndquadrant.com>
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Dimitri Fontaine <dimitri@2ndquadrant.fr>, Tom Lane <tgl@sss.pgh.pa.us>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2013-03-05T21:42:18Z
Lists: pgsql-hackers
Attachments
- dropped_objects.7.patch (text/x-diff) patch
Alvaro Herrera escribió: > Hmm, maybe I should be considering a pair of macros instead -- > UTILITY_START_DROP and UTILITY_END_DROP. I'll give this a try. Other > ideas are welcome. This seems to work. See attached; I like the result because there's no clutter and it supports all three cases without a problem. I also added a new output column to pg_event_trigger_dropped_objects, "subobject_name", which is NULL except when a column is being dropped, in which case it contains the column name. Also, the "object type" column now says "table column" instead of "table" when dropping a column. Another question arose in testing: this reports dropping of temp objects, too, but of course not always: particularly not when temp objects are dropped at the end of a session (or the beginning of a session that reuses a previously used temp schema). I find this rather inconsistent and I wonder if we should instead suppress reporting of temp objects. -- Álvaro Herrera http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services