Horton
Menu

Re: in-catalog Extension Scripts and Control parameters (templates?)

Andres Freund <andres@2ndquadrant.com>

View thread
From: Andres Freund <andres@2ndquadrant.com>
To: Dimitri Fontaine <dimitri@2ndQuadrant.fr>
Cc: Craig Ringer <craig@2ndquadrant.com>, Stephen Frost <sfrost@snowman.net>, Tom Lane <tgl@sss.pgh.pa.us>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2013-03-04T11:20:46Z
Lists: pgsql-hackers 
On 2013-03-04 11:51:36 +0100, Dimitri Fontaine wrote:
>   - Assert() HeapTuple's catalog
> 
>     In the function extract_ctlversion() I would like to be able to
>     Assert() that the given tuple is from the right catalog and didn't
>     see how to do that

->t_tableOid. Haven't read the patch, so I am not sure whether thats a
good check to make.

Its not 100% useful, because several places neglect to set tableOid but
I have patch to remedy that (as part of the logical decoding work).

I can send that patch separated from other stuff if there's interest.

Greetings,

Andres Freund

-- 
 Andres Freund	                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services