Horton

Re: Strange Windows problem, lock_timeout test request

Stephen Frost <sfrost@snowman.net>

View thread View on postgr.es
From: Stephen Frost <sfrost@snowman.net>
To: Andrew Dunstan <andrew@dunslane.net>
Cc: Boszormenyi Zoltan <zb@cybertec.at>, Hari Babu <haribabu.kommi@huawei.com>, 'Craig Ringer' <craig@2ndQuadrant.com>, 'Hans-Jürgen Schönig' <hs@cybertec.at>, 'Ants Aasma' <ants@cybertec.at>, 'Tom Lane' <tgl@sss.pgh.pa.us>, 'PostgreSQL Hackers' <pgsql-hackers@postgresql.org>, 'Amit kapila' <amit.kapila@huawei.com>
Date: 2013-02-24T03:15:08Z
Lists: pgsql-hackers 
* Andrew Dunstan (andrew@dunslane.net) wrote:
> Every unified diff can be turned into a context diff by passing it
> though "filterdiff --format=context".

On that point, annoyingly, it's not accurate for every diff.  In
particular, when I tried it with the diff for 'v29' of this lock_timeout
patch, it only returns the context diff for the first two files:

zcat 2-lock_timeout-v29.patch.gz | grep -- '--- postgresql' | wc -l
22

zcat 2-lock_timeout-v29.patch.gz | \
     filterdiff --format=context | \
	 grep '\*\*\* postgresql' | wc -l
2

In the end, I did create a local git branch, commit the patch, then
diff it back against master using my context-diff git helper to get
something easier to read through.  Rather annoying.

	Thanks,

		Stephen