Horton

Re: backend hangs at immediate shutdown (Re: Back-branch update releases coming in a couple weeks)

Andres Freund <andres@2ndquadrant.com>

View thread View on postgr.es
From: Andres Freund <andres@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: MauMau <maumau307@gmail.com>, pgsql-hackers@postgresql.org
Date: 2013-01-30T15:34:53Z
Lists: pgsql-hackers 
On 2013-01-30 10:23:09 -0500, Tom Lane wrote:
> "MauMau" <maumau307@gmail.com> writes:
> > When I ran "pg_ctl stop -mi" against the primary, some applications 
> > connected to the primary did not stop. ...
> > The root cause is that gettext() is called in the signal handler quickdie() 
> > via errhint().
> 
> Yeah, it's a known hazard that quickdie() operates like that.

What about not translating those? The messages are static and all memory
needed by postgres should be pre-allocated.

Greetings,

Andres Freund

-- 
 Andres Freund	                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services

Commits

  1. Consistency check should compare last record replayed, not last record read.

  2. Update minimum recovery point on truncation.