Re: Event Triggers: adding information
Andres Freund <andres@2ndquadrant.com>
From: Andres Freund <andres@2ndquadrant.com>
To: Craig Ringer <craig@2ndQuadrant.com>
Cc: Dimitri Fontaine <dimitri@2ndQuadrant.fr>, Tom Lane <tgl@sss.pgh.pa.us>, Simon Riggs <simon@2ndQuadrant.com>, Robert Haas <robertmhaas@gmail.com>, Alvaro Herrera <alvherre@2ndQuadrant.com>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2013-01-18T02:34:37Z
Lists: pgsql-hackers
On 2013-01-18 10:31:28 +0800, Craig Ringer wrote: > On 01/18/2013 09:33 AM, Andres Freund wrote: > > I have no problem requiring C code to use the even data, be it via > > hooks or via C functions called from event triggers. The problem I > > have with putting in some hooks is that I doubt that you can find > > sensible spots with enough information to actually recreate the DDL > > for a remote system without doing most of the work for command triggers. > > Is that so much of a problem if it's OK to break it between major > versions? Maybe require compilation with -DPG_NON_FORWARD_COMPATIBLE to > make the hooks visible in the headers, so nobody can claim they didn't know? I can't follow the connection between what you quote from my mail and what you are saying ;) The problem I see is providing enough information to the hooks, not cross version compatibility. If we go the hook route I don't have the slightest problem of breaking them in the next releases. Greetings, Andres Freund -- Andres Freund http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services