Re: Hot Standby conflict resolution handling
Abhijit Menon-Sen <ams@2ndquadrant.com>
From: Abhijit Menon-Sen <ams@2ndQuadrant.com>
To: Stephen Frost <sfrost@snowman.net>
Cc: Pavan Deolasee <pavan.deolasee@gmail.com>, Andres Freund <andres@2ndquadrant.com>, pgsql-hackers@postgresql.org
Date: 2013-01-17T03:56:49Z
Lists: pgsql-hackers
Attachments
- clarify-fatal-error-in-conflict-resolution.diff (text/x-diff) patch
At 2012-12-29 14:23:45 -0500, sfrost@snowman.net wrote:
>
> Regarding the actual comment, here's the wording that I'd use:
Sorry for nitpicking, but "we can't long jumps" made me cringe.
Here's a slightly more condensed version:
/*
* We can't use ereport(ERROR) here, because any longjmps
* in DoingCommandRead state run the risk of violating our
* protocol or the SSL protocol, by interrupting OpenSSL in
* the middle of changing its internal state.
*
* Currently, the only option is to promote ERROR to FATAL
* until we figure out a better way to handle errors in this
* state.
*/
Patch along these lines attached, which also removes trailing
whitespace from the original patch.
-- Abhijit