Re: logical changeset generation v4
Andres Freund <andres@2ndquadrant.com>
From: Andres Freund <andres@2ndquadrant.com>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: pgsql-hackers@postgresql.org
Date: 2013-01-15T18:30:35Z
Lists: pgsql-hackers
Attachments
- 0001-xlogreader-fix.patch (text/x-patch) patch 0001
- 0001-xlogreader-use-correct-type.patch (text/x-patch) patch 0001
On 2013-01-15 15:16:44 -0300, Alvaro Herrera wrote: > Andres Freund wrote: > > On 2013-01-15 09:56:41 -0300, Alvaro Herrera wrote: > > > Andres Freund wrote: > > > > On 2013-01-15 01:00:00 -0300, Alvaro Herrera wrote: > > > > > Andres Freund wrote: > > > > > > > > > > I've been giving a couple of these parts a look. In particular > > > > > > > > > > > [03] Split out xlog reading into its own module called xlogreader > > > > > > > > > > Cleaned this one up a bit last week. I will polish it some more, > > > > > publish for some final comments, and commit. > > > > > > > > I have some smaller bugfixes in my current version that you probably > > > > don't have yet (on grounds of being fixed this weekend)... So we need to > > > > be a bit careful not too loose those. > > > > > > Sure. Do you have them as individual commits? I'm assuming you rebased > > > the tree. Maybe in your reflog? IIRC I also have at least one minor > > > bug fix. > > > > I can check, which commit did you base your modifications on? > > Dunno. It's probably easier to reverse-apply the version you submitted > to see what changed, and then forward-apply again. There's at least the two attached patches... Greetings, Andres Freund -- Andres Freund http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services