Horton

Re: [PATCH 2/5] Make relpathbackend return a statically result instead of palloc()'ing it

Alvaro Herrera <alvherre@2ndquadrant.com>

View thread View on postgr.es
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Andres Freund <andres@2ndquadrant.com>, Tom Lane <tgl@sss.pgh.pa.us>, pgsql-hackers@postgresql.org
Date: 2013-01-08T22:37:01Z
Lists: pgsql-hackers 
Robert Haas escribió:

> And functions that return static buffers are evil incarnate.  I've
> spent way too much of my life dealing with the supreme idiocy that is
> fmtId().

+1

> If someone ever finds a way to make that go away, I will buy
> them a beverage of their choice at the next conference we're both at.

+1

-- 
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

Commits

  1. Prevent creation of postmaster's TCP socket during pg_upgrade testing.