Re: pg_stat_statements: calls under-estimation propagation
Alvaro Herrera <alvherre@2ndquadrant.com>
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Daniel Farina <daniel@fdr.io>
Cc: samthakur74 <samthakur74@gmail.com>,
pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2013-09-23T14:19:43Z
Lists: pgsql-hackers
Daniel Farina escribió: > On Fri, Sep 20, 2013 at 1:11 AM, Daniel Farina <daniel@fdr.io> wrote: > > I think the n-call underestimation propagation may not be quite precise for > > various detailed reasons (having to do with 'sticky' queries) and to make it > > precise is probably more work than it's worth. And, on more reflection, I'm > > also having a hard time imaging people intuiting that value usefully. So, > > here's a version removing that. > > I forgot about removal of the relevant SGML, amended here in v6. Nice. You need to remove the --1.1.sql entry (the file itself and the DATA entry in Makefile). Also, I think it would be good to have a common "fooRandom()" routine, instead of having a second copy of PostmasterRandom. Might I suggest putting it in a new file under src/common/. -- Álvaro Herrera http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services
Commits
Same data as JSON:
GET /api/v1/messages/:b64id/commits
the thread's linked commits as JSON, with link sources.
API reference →
-
Improve management of "sticky" entries in contrib/pg_stat_statements.
- d5375491f8e3 9.2.0 cited