Horton

Re: ALTER SYSTEM SET command to change postgresql.conf parameters (RE: Proposal for Allow postgresql.conf values to be changed via SQL [review])

Stephen Frost <sfrost@snowman.net>

View thread View on postgr.es
From: Stephen Frost <sfrost@snowman.net>
To: Martijn van Oosterhout <kleptog@svana.org>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>, Amit Kapila <amit.kapila16@gmail.com>, Robert Haas <robertmhaas@gmail.com>, Dimitri Fontaine <dimitri@2ndquadrant.fr>, Andres Freund <andres@2ndquadrant.com>, Josh Berkus <josh@agliodbs.com>, Tom Lane <tgl@sss.pgh.pa.us>, Fujii Masao <masao.fujii@gmail.com>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Date: 2013-08-21T14:52:01Z
Lists: pgsql-hackers 
Martijn,

* Martijn van Oosterhout (kleptog@svana.org) wrote:
> ISTM you want some kind of hybrid setting like:
> 
> #include_system auto.conf
> 
> which simultaneously does three things:
> 
> 1. Sets the enable_alter_system flag
> 2. Indicates the file to use
> 3. Indicates the priority of the setting re other settings.
> 
> Comment it out, ALTER SYSTEM stop working. Put it back and it's
> immediately clear what it means. And the user can control where the
> settings go.

Yeah, that's certainly an interesting idea.  I might call it
'auto_conf_file auto.conf' to avoid the '#include' concern and to
perhaps clarify that it's more than just a regular 'include'.

> Syntax is a bit fugly though.

Agreed.

	Thanks,

		Stephen
		(who is still unhappy about the GUC-specific handling for relative
		paths in postgresql.conf)