Horton
Menu

Re: pg_filedump 9.3: checksums (and a few other fixes)

Alvaro Herrera <alvherre@2ndquadrant.com>

View thread
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Peter Geoghegan <pg@heroku.com>, Jeff Davis <pgsql@j-davis.com>, Satoshi Nagayasu <snaga@uptime.jp>, Josh Kupershmidt <schmiddy@gmail.com>, Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2013-07-17T17:43:43Z
Lists: pgsql-hackers 
Tom Lane escribió:

> My feeling about this code is that the reason we print the infomask in
> hex is so you can see exactly which bits are set if you care, and that
> the rest of the line ought to be designed to interpret the bits in as
> reader-friendly a way as possible.  So I don't buy the notion that we
> should just print out a name for each bit that's set.  I'd rather
> replace individual bit names with items like LOCKED_FOR_KEY_SHARE,
> LOCKED_FOR_SHARE, etc in cases where you have to combine multiple
> bits to understand the meaning.

Okay, that's what I've been saying all along so I cannot but agree.  I
haven't reviewed Jeff's patch lately; Jeff, does Tom's suggestion need
some more new code, and if so are you open to doing this work, or shall
I?

-- 
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Refactor checksumming code to make it easier to use externally.