Horton

Re: patch submission: truncate trailing nulls from heap rows to reduce the size of the null bitmap [Review]

Noah Misch <noah@leadboat.com>

View thread View on postgr.es
From: Noah Misch <noah@leadboat.com>
To: Josh Berkus <josh@agliodbs.com>
Cc: Simon Riggs <simon@2ndQuadrant.com>, Tom Lane <tgl@sss.pgh.pa.us>, Amit Kapila <amit.kapila@huawei.com>, Andres Freund <andres@2ndquadrant.com>, Craig Ringer <craig@2ndquadrant.com>, Jameison Martin <jameisonb@yahoo.com>, Kevin Grittner <kgrittn@mail.com>, robertmhaas@gmail.com, pgsql-hackers@postgresql.org
Date: 2013-06-25T02:14:22Z
Lists: pgsql-hackers 
On Mon, Jun 24, 2013 at 01:32:41PM -0700, Josh Berkus wrote:
> Do we really have ironclad numbers which show that the patch affects
> performance negatively?  I didn't think the previous performance test
> was comprehensive; I was planning to develop one myself this week.

Not ironclad, no:
http://www.postgresql.org/message-id/20130124021205.GB29954@tornado.leadboat.com

-- 
Noah Misch
EnterpriseDB                                 http://www.enterprisedb.com

Commits

  1. Don't assume that a tuple's header size is unchanged during toasting.