Re: Patch for removng unused targets

Alvaro Herrera <alvherre@2ndquadrant.com>

From: Alvaro Herrera <alvherre@2ndquadrant.com>

To: Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>

Cc: 'Hitoshi Harada' <umi.tanuki@gmail.com>, 'Tom Lane' <tgl@sss.pgh.pa.us>, 'Alexander Korotkov' <aekorotkov@gmail.com>, 'pgsql-hackers' <pgsql-hackers@postgresql.org>

Date: 2013-06-24T22:39:12Z

Lists: pgsql-hackers

Attachments

unused-targets-20130624.patch (text/x-diff) patch

Etsuro Fujita escribió:
> > From: Hitoshi Harada [mailto:umi.tanuki@gmail.com]
> 
> > I tried several ways but I couldn't find big problems.  Small typo:
> > s/rejunk/resjunk/
> 
> Thank you for the review.  Attached is an updated version of the patch.

Thanks.  I gave this a look, and made it some trivial adjustments.
Attached is the edited version.  I think this needs some more (succint)
code comments:

. why do we want to remove these entries
. why can't we do it in the DISTINCT case
. why don't we remove the cases we don't remove, within adjust_targetlist().

-- 
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services