Horton

Re: backend hangs at immediate shutdown (Re: Back-branch update releases coming in a couple weeks)

Alvaro Herrera <alvherre@2ndquadrant.com>

View thread View on postgr.es
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: MauMau <maumau307@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Andres Freund <andres@2ndquadrant.com>, Peter Eisentraut <peter_e@gmx.net>, pgsql-hackers@postgreSQL.org
Date: 2013-06-21T02:39:28Z
Lists: pgsql-hackers 
MauMau escribió:
> From: "Alvaro Herrera" <alvherre@2ndquadrant.com>

> One concern is that umount would fail in such a situation because
> postgres has some open files on the filesystem, which is on the
> shared disk in case of traditional HA cluster.

See my reply to Noah.  If postmaster stays around, would this be any
different?  I don't think so.

> >IIRC the only other interesting tweak I did was rename the
> >SignalAllChildren() function to TerminateChildren().  I did this because
> >it doesn't really signal all children; syslogger and dead_end backends
> >are kept around.  So the original name was a bit misleading.  And we
> >couldn't really name it SignalAlmostAllChildren(), could we ..
> 
> I see.  thank you.

Actually, in further testing I noticed that the fast-path you introduced
in BackendCleanup (or was it HandleChildCrash?) in the immediate
shutdown case caused postmaster to fail to clean up properly after
sending the SIGKILL signal, so I had to remove that as well.  Was there
any reason for that?

-- 
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

Commits

  1. Consistency check should compare last record replayed, not last record read.

  2. Update minimum recovery point on truncation.