Re: fix bgworkers in EXEC_BACKEND

Alvaro Herrera <alvherre@2ndquadrant.com>

From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Heikki Linnakangas <hlinnakangas@vmware.com>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2012-12-27T20:46:45Z
Lists: pgsql-hackers

Attachments

Heikki Linnakangas wrote:

> Might be cleaner to directly assign the correct value to MaxBackends
> above, ie. "MaxBackends =  MaxConnections + newval + 1 +
> GetNumShmemAttachedBgworkers()". With a comment to remind that it
> needs to be kept in sync with the other places where that
> calculation is done, in guc.c. Or put that calculation in a new
> function and call it above and in guc.c.
> 
> Thinking about this some more, it might be cleaner to move the
> responsibility of setting MaxBackends out of guc.c, into
> postmaster.c. The guc machinery would set max_connections and
> autovacuum_max_workers as usual, but not try to set MaxBackends.
> After reading the config file in postmaster.c, calculate
> MaxBackends.

Here's a small patch that applies on top of yours.  Do you intend to
commit this?  If not, let me know and I'll do it.

Thanks.

-- 
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services