Horton

Re: Re: patch submission: truncate trailing nulls from heap rows to reduce the size of the null bitmap [Review]

Kevin Grittner <kgrittn@mail.com>

View thread View on postgr.es
From: "Kevin Grittner" <kgrittn@mail.com>
To: "Simon Riggs" <simon@2ndQuadrant.com>,"Amit Kapila" <amit.kapila@huawei.com>
Cc: robertmhaas@gmail.com,josh@agliodbs.com,pgsql-hackers@postgresql.org
Date: 2012-12-24T14:28:10Z
Lists: pgsql-hackers 
Simon Riggs wrote:

> Not really sure about the 100s of columns use case.
> 
> But showing gain in useful places in these more common cases wins
> my vote.
> 
> Thanks for testing. Barring objections, will commit.

Do we have any results on just a plain, old stock pgbench run, with
the default table definitions?

That would be a reassuring complement to the other tests.

-Kevin

Commits

  1. Don't assume that a tuple's header size is unchanged during toasting.