Re: pgsql: Add mode where contrib installcheck runs each module in a separa

Andrew Dunstan wrote:

> On 12/03/2012 01:45 PM, Alvaro Herrera wrote:

> >../../src/test/regress/pg_regress --inputdir=/pgsql/source/bgworker/contrib/dblink --psqldir='/pgsql/install/bgworker/bin'   --dbname=contrib_regression_dblink dblink
> >(using postmaster on Unix socket, default port)
> >============== dropping database "contrib_regression_dblink" ==============
> >psql: could not connect to server: No such file or directory
> >         Is the server running locally and accepting
> >         connections on Unix domain socket "/tmp/.s.PGSQL.55440"?
> >command failed: "/pgsql/install/bgworker/bin/psql" -X -c "DROP DATABASE IF EXISTS \"contrib_regression_dblink\"" "postgres"
> >make: *** [installcheck] Error 2
> 
> Well, you seem to have more problems than just the database name.

Obviously I didn't have the server running at that point, but surely
that's not relevant; what I'm pointing out is that make is not taking
notice of the variable override.

> This seems rather odd, though. What more can you tell us about the
> platform etc.?

This is Debian Squeeze running on amd64.  There's nothing really odd
about it; it's my everyday platform.

> I note you have "USE_MODULE_DB=q" where I'm using
> "USE_MODULE_DB=1". Do you get the same failure when you don't define
> USE_MODULE_DB?

Yes.  I wasn't testing this patch, and I wasn't testing pg_upgrade
either; I was just running a full rebuild and noticed that message.
So initially I obviously hadn't set any variable at all.

I cleaned up everything up including autoconf cache, removed VPATH build
dir, git clean -dfx, and it's still there.

-- 
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services