Horton
Menu

Re: splitting *_desc routines

Alvaro Herrera <alvherre@2ndquadrant.com>

View thread
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Simon Riggs <simon@2ndQuadrant.com>, Tom Lane <tgl@sss.pgh.pa.us>
Cc: Robert Haas <robertmhaas@gmail.com>, Andres Freund <andres@2ndquadrant.com>, pgsql-hackers@postgresql.org
Date: 2012-11-27T16:10:22Z
Lists: pgsql-hackers

Attachments

Simon Riggs escribió:
> On 23 November 2012 22:52, Alvaro Herrera <alvherre@2ndquadrant.com> wrote:
> 
> > ./access/rmgrdesc/xact_desc.c
> > ./access/rmgrdesc/heapdesc.c
> 
> Could we have either all underscores _ or none at all for the naming?

Sure, removed them all.


Tom Lane escribió:

> FWIW, I'd vote for dumping all of these into *one* rmgrdesc directory
> (which may as well be under access/ since that's where the xlog code is),
> regardless of where the corresponding replay code is in the source tree.
> I don't think splitting them up into half a dozen directories adds
> anything except confusion.  If you want, the header comment for each
> file could mention where the corresponding replay code lives.

Done that way.

-- 
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services