Horton
Menu

Re: [PATCH] binary heap implementation

Abhijit Menon-Sen <ams@2ndquadrant.com>

View thread
From: Abhijit Menon-Sen <ams@2ndQuadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@postgresql.org, Robert Haas <robertmhaas@gmail.com>, Andres Freund <andres@2ndQuadrant.com>
Date: 2012-11-21T05:15:53Z
Lists: pgsql-hackers 
At 2012-11-20 22:55:52 -0500, tgl@sss.pgh.pa.us wrote:
>
> BTW, I probably missed some context upthread, but why do we have two
> fields at all?

I would also have preferred to handle the nodeMergeAppend case using a
context pointer as you suggest, but Andres needs to store two pointers
in his heap nodes.

Andres: suppose we replace binaryheap_node with just a Datum, could you
live with storing a pointer to a struct with two pointers? If so, that
would address the concerns raised.

If not, maybe we should explore Robert's earlier suggestion to make
binaryheap_node user-definable (in effect).

-- Abhijit

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Fix memory leaks in record_out() and record_send().