Horton
Menu

Re: [PATCH] binary heap implementation

Alvaro Herrera <alvherre@2ndquadrant.com>

View thread
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Abhijit Menon-Sen <ams@2ndquadrant.com>, pgsql-hackers@postgresql.org
Date: 2012-11-15T15:21:49Z
Lists: pgsql-hackers 
Robert Haas escribió:
> On Wed, Nov 14, 2012 at 8:11 AM, Abhijit Menon-Sen <ams@2ndquadrant.com> wrote:
> > Comments? Suggestions?
> 
> It could use a run through pgindent.  And the header comments are
> separated by a blank line from the functions to which they are
> attached, which is not project style.

Also there are some comments in the .h file which we typically don't
carry.

> Other than the coding style issues, I think this looks fine.  If you
> can fix that up, I believe I could go ahead and commit this, unless
> anyone else objects.

Does this include the changes in nodeMergeappend.c?

-- 
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Fix memory leaks in record_out() and record_send().