Re: Fix errcontext() function
Alvaro Herrera <alvherre@2ndquadrant.com>
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Heikki Linnakangas <hlinnakangas@vmware.com>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2012-11-12T15:52:59Z
Lists: pgsql-hackers
Heikki Linnakangas wrote: > On 10.11.2012 11:46, Chen Huajun wrote: > >>Unfortunately not all compilers support varargs macros. I bumped into > >>this in February, see > >>http://archives.postgresql.org/message-id/4F3B72E0.8040801@enterprisedb.com. > >>My last attempt to fix this was > >>at http://archives.postgresql.org/pgsql-hackers/2012-04/msg00812.php. > >>That patch is probably good to go, I just got busy with other things > >>and forgot about it back then. Can you take a look at that > >>patch and see if I missed anything, please? > > > >I think you are right,although the number of changed place is a a little > >bit large. > >Thanks for your answer! > > Ok, I've committed this patch now, it will be fixed in 9.3. Thanks > for reminding me about this. Hopefully you noticed that contrib is broken. --