Re: splitting *_desc routines
Alvaro Herrera <alvherre@2ndquadrant.com>
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Andres Freund <andres@2ndquadrant.com>, pgsql-hackers@postgresql.org, Tom Lane <tgl@sss.pgh.pa.us>
Date: 2012-10-24T20:44:35Z
Lists: pgsql-hackers
Attachments
- splitdesc.patch (text/x-diff) patch
Here's a small WIP patch that does the proposed splitting. This is a first step towards the objective of having a separately compilable xlogdump -- more work is needed before that can be made to work fully. Now, per previous discussion, I have split each rmgr's desc function into its own file. This is easiest, but it leaves us with several very small files in some directories; for example we have ./src/backend/access/transam/clog_desc.c ./src/backend/access/transam/xact_desc.c ./src/backend/access/transam/xlog_desc.c ./src/backend/access/transam/mxact_desc.c and also ./src/backend/commands/dbase_desc.c ./src/backend/commands/seq_desc.c ./src/backend/commands/tablespace_desc.c Is people okay with that, or should we consider merging each subdir's files into a single one? (say transam_desc.c and cmds_desc.c). The other question is whether the function and struct declarations are in the best possible locations considering that we will want the files to be compilable without a backend environment. I am using xlogdump as a testbed to ensure that everything is kosher (it's not yet there for other reasons -- I might end up using something other than xlog_internal.h, for example). Once we settle these issues, I will finish up the patch by adding nice file header comments and the like. -- Álvaro Herrera http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services