Re: Extend argument of OAT_POST_CREATE
Alvaro Herrera <alvherre@2ndquadrant.com>
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Kohei KaiGai <kaigai@kaigai.gr.jp>
Cc: Robert Haas <robertmhaas@gmail.com>, PgHacker <pgsql-hackers@postgresql.org>
Date: 2012-10-23T21:34:58Z
Lists: pgsql-hackers
Kohei KaiGai escribió: > 2012/10/10 Alvaro Herrera <alvherre@2ndquadrant.com>: > > I admit the new RELKIND_INDEX cases in various places make for strange > > flow. Not sure how it can be improved though. > > > The idea is not so complicated. This code considers index is an > property of a certain table like as individual field of pg_class. > Relation is the most complex object in PostgreSQL. Its property > is not only ones in pg_class, but some extra catalogs such as > pg_trigger, pg_rewrite and so on. I have pushed this patch with some slight changes in the way the RELKIND_INDEX case is handled in various places, to make it clearer. I may have broken some cases; please have a look. Thanks. -- Álvaro Herrera http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services