Horton
Menu

Re: FDW for PostgreSQL

Alvaro Herrera <alvherre@2ndquadrant.com>

View thread
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Shigeru HANADA <shigeru.hanada@gmail.com>
Cc: Kohei KaiGai <kaigai@kaigai.gr.jp>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2012-10-23T15:35:23Z
Lists: pgsql-hackers 
Shigeru HANADA escribió:

> Please examine attached v2 patch (note that is should be applied onto
> latest dblink_fdw_validator patch).

Tom committed parts of the dblink_fdw_validator patch, but not the
removal, so it seems this patch needs to be rebased on top of that
somehow.  I am not able to say what's the best resolution for that
conflict, however.  But it seems to me that maybe you will need to
choose a different name for the validator after all, to support binary
upgrades.

There are some other comments downthread that a followup patch probably
needs to address too, as well.  I am marking this patch Returned with
Feedback.  Please submit an updated version to CF3.

Thanks.

-- 
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services