Re: Switching timeline over streaming replication
Alvaro Herrera <alvherre@2ndquadrant.com>
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Heikki Linnakangas <hlinnakangas@vmware.com>
Cc: Amit Kapila <amit.kapila@huawei.com>, 'PostgreSQL-development' <pgsql-hackers@postgreSQL.org>
Date: 2012-10-23T15:05:34Z
Lists: pgsql-hackers
Heikki Linnakangas wrote: > Attached is a new version of the patch. I committed the refactoring > of XLogPageRead() already, as that was a readability improvement > even without this patch. All the reported issues should be fixed > now, although I will continue testing this tomorrow. I added various > checks that that the correct timeline is followed during recovery. > minRecoveryPoint is now accompanied by a timeline ID, so that when > we restart recovery, we check that we recover back to > minRecoveryPoint along the same timeline as last time. Also, it now > checks at beginning of recovery that the checkpoint record comes > from the correct timeline. That fixes the problem that you reported > above. I also adjusted the error messages on timeline history > problems to be more clear. Heikki, I see Amit found a problem with this patch. I assume you're going to work a bit more on it and submit/commit another version. I'm marking this one Returned with Feedback. Thanks. -- Álvaro Herrera http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services