Horton
Menu

Re: Libxml2 load error on Windows

Noah Misch <noah@leadboat.com>

View thread
From: Noah Misch <noah@leadboat.com>
To: Talha Bin Rizwan <talha.rizwan@gmail.com>
Cc: pgsql-hackers@postgresql.org
Date: 2012-10-08T11:59:45Z
Lists: pgsql-hackers 
On Mon, Jun 18, 2012 at 02:08:29PM +0500, Talha Bin Rizwan wrote:
> PostgreSQL 9.2 Windows build is having trouble with the XML support:
> http://postgresql.1045698.n5.nabble.com/9-2-beta1-libxml2-can-t-be-loaded-on-Windows-td5710672.html

> Therefore, I used first approach to get libxml2 version number and include
> the "#define HAVE_XMLSTRUCTUREDERRORCONTEXT" in pg_config.h if libxml2 version
> is greater than 20703 (which effectively is 2.7.3). Please find attached
> patch "libxml2_win_v1.patch".

Tom fixed this differently; effectively, we now use a check like you describe
on all platforms, not just Windows:

http://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=470d0b9789981bc91a8ef2654911d80ab6a6be57

Since that commit makes your patch obsolete, I'm marking it Rejected.  Even
so, thank you for calling attention to the problem and submitting this fix.

nm

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Check LIBXML_VERSION instead of testing in configure script.