Horton

Re: Command Triggers, patch v11

Andres Freund <andres@anarazel.de>

View thread
From: Andres Freund <andres@anarazel.de>
To: pgsql-hackers@postgresql.org
Cc: Thom Brown <thom@linux.com>, Dimitri Fontaine <dimitri@2ndquadrant.fr>, Tom Lane <tgl@sss.pgh.pa.us>
Date: 2012-03-04T15:50:39Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Fix SPGiST vacuum algorithm to handle concurrent tuple motion properly.

  2. Remove useless const qualifier

  3. Make executor's SELECT INTO code save and restore original tuple receiver.

Attachments

Hi,

On Saturday, March 03, 2012 01:08:33 AM Thom Brown wrote:
> On 2 March 2012 23:33, Thom Brown <thom@linux.com> wrote:
> > On 2 March 2012 22:32, Dimitri Fontaine <dimitri@2ndquadrant.fr> wrote:
> >>>> test=# CREATE TABLE badname (id int, a int, b text);
> >>>> ERROR:  invalid relation name: badname
> >>>> test=# CREATE TABLE badname AS SELECT 1::int id, 1::int a, ''::text b;
> >>>> SELECT 1
> >>>> 
> >>>> This doesn't even get picked up by ANY COMMAND.
> >> 
> >> I think Andres should add an entry for his patch on the commitfest.  Is
> >> it ok?
> > 
> > I'll try Andres' patch this weekend while I test yours.
> 
> Actually no matter which patch I apply first, they cause the other to
> fail to apply.
Ok, I rebased my patch ontop of dim's current HEAD. There was only one trivial 
conflict in tablecmds.h. I had written the patch independently of the command 
triggers stuff because I though, and still do, that would make applying it 
easier.

Attached are two versions of the patch, one based on command triggers and one 
without. Both pass regression tests for me.

Andres