Re: Speed dblink using alternate libpq tuple storage

Marko Kreen <markokr@gmail.com>

View thread

From: Marko Kreen <markokr@gmail.com>

To: Kyotaro HORIGUCHI <horiguchi.kyotaro@oss.ntt.co.jp>

Cc: mmoncure@gmail.com, pgsql-hackers@postgresql.org, greg@2ndquadrant.com

Date: 2012-02-02T14:30:57Z

Lists: pgsql-hackers

Attachments

libpq_rowproc_2012-02-02-2.diff (text/x-diff) patch 2012
libpq_rowproc_doc_2012-02-02-2.diff (text/x-diff) patch 2012
dblink_rowproc_2012-02-02-2.diff (text/x-diff) patch 2012

On Thu, Feb 02, 2012 at 04:51:37PM +0900, Kyotaro HORIGUCHI wrote:
> Hello, This is new version of dblink.c
> 
> - Memory is properly freed when realloc returns NULL in storeHandler().
> 
> - The bug that free() in finishStoreInfo() will be fed with
>   garbage pointer when malloc for sinfo->valbuflen fails is
>   fixed.

Thanks, merged.  I also did some minor coding style cleanups.

Tagging it Ready For Committer.  I don't see any notable
issues with the patch anymore.

There is some potential for experimenting with more aggressive
optimizations on dblink side, but I'd like to get a nod from
a committer for libpq changes first.

-- 
marko