Re: proposal: better support for debugging of overloaded functions

Abhijit Menon-Sen <ams@toroid.org>

From: Abhijit Menon-Sen <ams@toroid.org>
To: Pavel Stehule <pavel.stehule@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>, pgsql-hackers@postgresql.org
Date: 2012-01-26T15:28:12Z
Lists: pgsql-hackers

Attachments

At 2011-11-24 17:44:16 +0100, pavel.stehule@gmail.com wrote:
>
> patch is relative long, but almost all are changes in regress tests.
> Changes in plpgsql are 5 lines

The change looks good in principle. The patch applies to HEAD with a bit
of fuzz and builds fine… but it fails tests, because it's incomplete.

Pavel, your patch doesn't contain any changes to pl_exec.c. Did you just
forget to submit them? Anyway, some errcontext() calls need to be taught
to print ->fn_signature rather than ->fn_name. I made those changes, and
found some more failing tests.

Updated patch attached. Ready for committer.

-- ams