Horton

Re: Avoid FK validations for no-rewrite ALTER TABLE ALTER TYPE

Noah Misch <noah@leadboat.com>

View thread
From: Noah Misch <noah@leadboat.com>
To: Jeff Janes <jeff.janes@gmail.com>
Cc: pgsql-hackers@postgresql.org
Date: 2012-01-22T05:05:31Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Damage control for yesterday's CheckIndexCompatible changes.

Attachments

On Sat, Jan 21, 2012 at 08:04:20PM -0800, Jeff Janes wrote:
> This is failing "make check" for me.
> 
> 
> *** /tmp/foo/src/test/regress/expected/alter_table.out  Sat Jan 21 19:51:46 2012
> --- /tmp/foo/src/test/regress/results/alter_table.out   Sat Jan 21 19:54:18 2012
> ***************
> *** 1662,1667 ****
> --- 1662,1668 ----
>   NOTICE:  CREATE TABLE / PRIMARY KEY will create implicit index
> "norewrite1_parent_pkey" for table "norewrite1_parent"
>   DEBUG:  building index "norewrite1_parent_pkey" on table "norewrite1_parent"
>   CREATE TABLE norewrite1_child(c text REFERENCES norewrite1_parent);
> + DEBUG:  building index "pg_toast_41491_index" on table "pg_toast_41491"
>   ALTER TABLE norewrite1_child ALTER c TYPE varchar; -- recheck FK
>   DEBUG:  validating foreign key constraint "norewrite1_child_c_fkey"
>   CREATE DOMAIN other_int AS int;

Thanks.  I've attached a new version fixing this problem.