Re: Command Triggers

Andres Freund <andres@anarazel.de>

From: Andres Freund <andres@anarazel.de>

To: Alvaro Herrera <alvherre@commandprompt.com>

Cc: Dimitri Fontaine <dimitri@2ndquadrant.fr>, Tom Lane <tgl@sss.pgh.pa.us>, Robert Haas <robertmhaas@gmail.com>, Pg Hackers <pgsql-hackers@postgresql.org>, Greg Smith <greg@2ndquadrant.com>, Bruce Momjian <bruce@momjian.us>

Date: 2012-01-18T19:25:48Z

Lists: pgsql-hackers

On Wednesday, January 18, 2012 08:17:36 PM Alvaro Herrera wrote:
> Excerpts from Dimitri Fontaine's message of mié ene 18 16:03:29 -0300 2012:
> > At the moment the trigger functions are called from
> > standard_ProcessUtility() and are given the parse tree as handed over to
> > that function, before the parse analysis.
> > 
> > We can easily enough copy the parse tree and do another round of parse
> > analysis on it only when some command triggers are going to get called.
> > Is the cost of doing so acceptable?
> 
> Huh, isn't it simpler to just pass the triggers the parse tree *after*
> parse analysis?  I don't understand what you're doing here.
Parse analysis is not exactly nicely separated for utility statements.

Andres