Horton
Menu

Re: embedded list v2

Andres Freund <andres@2ndquadrant.com>

View thread
From: Andres Freund <andres@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@postgresql.org, Alvaro Herrera <alvherre@2ndquadrant.com>, Robert Haas <robertmhaas@gmail.com>, Peter Geoghegan <peter@2ndquadrant.com>
Date: 2012-09-28T23:42:49Z
Lists: pgsql-hackers 
On Saturday, September 29, 2012 01:39:03 AM Tom Lane wrote:
> Andres Freund <andres@2ndquadrant.com> writes:
> > The reason I had the header declare DEFINE_ILIST_FUNCTIONS (or rather
> > ILIST_USE_DEFINITION back then) instead of reusing USE_INLINE directly is
> > that it makes it easier to locally change a "module" to not inlining
> > which makes testing the !USE_INLINE case easier. Does anybody think this
> > is worth something? I have no strong feelings but found it convenient.
> 
> Right offhand it doesn't seem like it really gains that much even for
> that use-case.  You'd end up editing the include file either way, just
> slightly differently.
Well, with USE_INLINE you have to recompile the whole backend because you 
otherwise easily end up with strange incompatibilities between files.

Andres
-- 
 Andres Freund	                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Provide some static-assertion functionality on all compilers.

  2. Add infrastructure for compile-time assertions about variable types.

  3. Remove 576 references of include files that were not needed.

  4. More include file adjustments.

  5. Allow each C include file to compile on its own by including any needed