Re: [ADMIN] pg_upgrade from 9.1.3 to 9.2 failed

On Sun, Sep 23, 2012 at 06:46:33PM -0400, Peter Eisentraut wrote:
> On Sun, 2012-09-23 at 22:20 +0800, Rural Hunter wrote:
> > Ah yes, seems I used a wrong parameter. The --locale='zh_CN.utf8' 
> > works. --locale='zh_CN.UTF8' also works. But still the question is, 
> > should the encoding name be case sensitive?
> 
> PostgreSQL treats encoding names as case insensitive.
> 
> But it depends on the operating system whether locale names are case
> sensitive.

I can confirm that pg_upgrade does case-insensitive comparisons of
encoding/locale names:

	static void
	check_locale_and_encoding(ControlData *oldctrl,
	                          ControlData *newctrl)
	{
	    /* These are often defined with inconsistent case, so use pg_strcasecmp(). */
	    if (pg_strcasecmp(oldctrl->lc_collate, newctrl->lc_collate) != 0)
	        pg_log(PG_FATAL,
	               "old and new cluster lc_collate values do not match\n");
	    if (pg_strcasecmp(oldctrl->lc_ctype, newctrl->lc_ctype) != 0)
	        pg_log(PG_FATAL,
	               "old and new cluster lc_ctype values do not match\n");
	    if (pg_strcasecmp(oldctrl->encoding, newctrl->encoding) != 0)
	        pg_log(PG_FATAL,
	               "old and new cluster encoding values do not match\n");
	}

-- 
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + It's impossible for everything to be true. +