Re: 9.2 pg_upgrade regression tests on WIndows

On Wed, Sep  5, 2012 at 10:46:17PM -0400, Andrew Dunstan wrote:
> 
> On 09/05/2012 10:41 PM, Bruce Momjian wrote:
> >
> >I would like to see a more verbose comment, so we don't forget why we
> >did this.  I think my inability to quickly discover the cause of the
> >previous log write problem is that I didn't document which file
> >descriptors are kept open on Windows.  I suggest for a comment:
> >
> >	/*
> >	 * "pg_ctl -w stop" might have reported that the server has
> >	 * stopped because the postmaster.pid file has been removed,
> >	 * but "pg_ctl -w start" might still be in the process of
> >	 * closing and might still be holding its stdout and -l log
> >	 * file descriptors open.  Therefore, try to open the log
> >	 * file a few times.
> >	 */
> >
> >Anyway, we can easily adjust the comment post-9.2.0.
> 
> 
> Shall I apply the patch now? If so I'll include your comment.

Well, seems it is a crash bug.  Apply so we can get some buildfarm
testing overnight.

-- 
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + It's impossible for everything to be true. +