Re: -Wformat-zero-length

Bruce Momjian <bruce@momjian.us>

From: Bruce Momjian <bruce@momjian.us>

To: Alvaro Herrera <alvherre@alvh.no-ip.org>

Cc: Tom Lane <tgl@sss.pgh.pa.us>, Peter Eisentraut <peter_e@gmx.net>, Pg Hackers <pgsql-hackers@postgresql.org>

Date: 2012-08-03T17:32:21Z

Lists: pgsql-hackers

On Fri, Aug  3, 2012 at 12:53:22PM -0400, Álvaro Herrera wrote:
> Excerpts from Bruce Momjian's message of vie ago 03 12:44:35 -0400 2012:
> 
> > I changed a prep_status() call to pg_log() as you suggested, and
> > backpatched to 9.2.  Patch attached.
> 
> I dunno about this particular patch, but if we ever want to move
> pg_upgrade out of contrib we will have to stare hard at it to improve
> translatability of the messages it emits.

Agreed.

> How ready are we to move it to src/bin/?  Is it sensible to do so in
> 9.3?

We have talked about that.  Several people felt the instructions for
using pg_upgrade was already too complex and that it isn't a
general-user utility like pg_dump.  Not sure if that is still the
general feeling.

-- 
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + It's impossible for everything to be true. +