Horton
Menu

Re: embedded list v2

Andres Freund <andres@2ndquadrant.com>

View thread
From: Andres Freund <andres@2ndquadrant.com>
To: pgsql-hackers@postgresql.org
Cc: Peter Geoghegan <peter@2ndquadrant.com>, Robert Haas <robertmhaas@gmail.com>, Tom Lane <tgl@postgresql.org>
Date: 2012-07-23T11:06:28Z
Lists: pgsql-hackers 
On Monday, July 23, 2012 12:55:01 PM Peter Geoghegan wrote:
> On 5 July 2012 02:49, Peter Geoghegan <peter@2ndquadrant.com> wrote:
> > On 28 June 2012 19:20, Andres Freund <andres@2ndquadrant.com> wrote:
> >> <0001-Add-embedded-list-interface.patch>
> >> 
> >> Looks good now?
> > 
> > I have a few gripes.
> 
> We are passed the nominal deadline. Had you planned on getting back to
> me this commitfest? If not, I'll shelve my review of
> "0002-Remove-usage-of-lib-dllist.h-and-replace-it-by-the-n.patch"
> until commitfest 2012-09, and mark this "returned with feedback".
I was actually waiting for the second review ;). Sorry for the 
misunderstanding.

There is no rule that review cannot happen outside the commitfest, so I would 
appreciate if we could push this further...

Andres
-- 
 Andres Freund	                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Provide some static-assertion functionality on all compilers.

  2. Add infrastructure for compile-time assertions about variable types.

  3. Remove 576 references of include files that were not needed.

  4. More include file adjustments.

  5. Allow each C include file to compile on its own by including any needed