Thread

  1. Update comments for PGPROC/PGXACT split

    Noah Misch <noah@leadboat.com> — 2012-05-13T20:52:31Z

    Many comment references to PGPROC and MyProc should now refer to PGXACT and
    MyPgXact.  This patch attempts to cover all such cases.  In some places, a
    comment refers collectively to all the xid-related fields, which span both
    structures.  I variously changed those to refer to either or both structures
    depending on how I judged the emphasis.
    
    The PGXACT patch extracted the PGPROC struct formerly embedded in each
    GlobalTransaction.  I updated a few comments accordingly.
    
    The procarray.c leading comment described the procarray as "unsorted", but it
    is sorted by memory address; I removed that word.
    
    I include two typo-only fixes on related but already-accurate lines.
    
    Thanks,
    nm
    
  2. Re: Update comments for PGPROC/PGXACT split

    Heikki Linnakangas <heikki.linnakangas@enterprisedb.com> — 2012-05-14T07:30:37Z

    On 13.05.2012 23:52, Noah Misch wrote:
    > Many comment references to PGPROC and MyProc should now refer to PGXACT and
    > MyPgXact.  This patch attempts to cover all such cases.  In some places, a
    > comment refers collectively to all the xid-related fields, which span both
    > structures.  I variously changed those to refer to either or both structures
    > depending on how I judged the emphasis.
    >
    > The PGXACT patch extracted the PGPROC struct formerly embedded in each
    > GlobalTransaction.  I updated a few comments accordingly.
    >
    > The procarray.c leading comment described the procarray as "unsorted", but it
    > is sorted by memory address; I removed that word.
    >
    > I include two typo-only fixes on related but already-accurate lines.
    
    Thanks, applied!
    
    -- 
       Heikki Linnakangas
       EnterpriseDB   http://www.enterprisedb.com