Re: psql omits row count under "\x auto"
Noah Misch <noah@leadboat.com>
From: Noah Misch <noah@leadboat.com>
To: Peter Eisentraut <peter_e@gmx.net>
Cc: pgsql-hackers@postgresql.org
Date: 2012-04-27T19:05:41Z
Lists: pgsql-hackers
Attachments
- expanded-auto-rowcount-v1.patch (text/plain) patch v1
On Thu, Apr 26, 2012 at 09:25:25PM +0300, Peter Eisentraut wrote: > On m??n, 2012-04-23 at 12:30 -0400, Noah Misch wrote: > > I've been enjoying "\x auto" in .psqlrc, but I noticed the row count footer > > missing when it chooses ordinary output: > > > Looks like the logic in printQuery() needs further treatment. > > Hmm, this looks a bit tricky, because at the time we add the footer we > don't yet know which output format will be used. I don't have a good > idea how to fix that at the moment. I fiddled with this and settled on moving the default_footer boolean setting and the interpretation thereof down from the printQuery() level to the printTable() level. That permits delaying the decision until we determine whether the final output format is indeed vertical.