Re: Patch - Debug builds without optimization

Bruce Momjian <bruce@momjian.us>

From: Bruce Momjian <bruce@momjian.us>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Peter Eisentraut <peter_e@gmx.net>, Greg Smith <greg@2ndQuadrant.com>, pgsql-hackers@postgresql.org
Date: 2011-11-30T00:13:49Z
Lists: pgsql-hackers

Attachments

Tom Lane wrote:
> Peter Eisentraut <peter_e@gmx.net> writes:
> > On tis, 2011-11-29 at 16:32 -0500, Bruce Momjian wrote:
> >> I have applied the attached patch to help make suggestsions for server
> >> developers.  I didn't reproduce most of the text because it was already
> >> listed with the options.  Let me know if you want additional text.
> 
> > Advising "server developers" to use CFLAGS="-O0 -g", without
> > qualification, is dangerous, in my mind, because that loses a lot of
> > compiler checks.  The only reason to use -O0 is when you really need to
> > debug something in single steps and you can't make sense of it any other
> > way.
> 
> Yes.  -O0 is really a pretty horrid default choice, and we should NOT be
> recommending it, especially not with no discussion of the disadvantages.

I have applied the attached patch to mention the debugger.  OK?

-- 
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + It's impossible for everything to be true. +