Re: perltidy

Bruce Momjian <bruce@momjian.us>

View thread

From: Bruce Momjian <bruce@momjian.us>

To: Peter Eisentraut <peter_e@gmx.net>

Cc: pgsql-hackers <pgsql-hackers@postgresql.org>

Date: 2011-11-29T02:58:32Z

Lists: pgsql-hackers

Attachments

/rtmp/perl (text/x-diff) patch

Peter Eisentraut wrote:
> How much do we care about applying perltidy, as described in
> src/tools/msvc/README, everywhere?  I just ran it across the entire
> tree, using
> 
> perltidy -b -bl -nsfs -naws -l=100 -ole=unix **/*.pl **/*.pm
> 
> and it generated 6531 lines of (unified) diff, of which 357 are in
> src/tools/msvc/ itself.  So clearly it's not being applied very
> consistently.
> 
> Given how easily this appears to work and how we're sneakily expanding
> the use of Perl, I think we ought to add this to the standard pgindent
> routine.

I have moved the Perl indentation command-line docs into the pgindent
README and it will be run as part of the pgindent checklist.  Applied
patch attached.

-- 
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + It's impossible for everything to be true. +