Re: pgsql: Make pg_dumpall build with the right object files under MSVC.

Bruce Momjian <bruce@momjian.us>

From: Bruce Momjian <bruce@momjian.us>

To: Andrew Dunstan <andrew@dunslane.net>

Cc: pgsql-committers@postgresql.org

Date: 2011-11-28T16:33:14Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Make pg_dumpall build with the right object files under MSVC.
- 91572ee0a6df 9.2.0 cited

Andrew Dunstan wrote:
> Make pg_dumpall build with the right object files under MSVC.
> 
> This fixes a longstanding but up to now benign bug in the way pg_dumpall
> was built. The bug was exposed by recent code adjustments. The Makefile
> does not use $(OBJS) to build pg_dumpall, so this fix removes their source
> files from the pg_dumpall object and adds in the one source file it
> consequently needs.

In summary, for those watching, pg_dump and pg_restore used to share
OBJS, and with my new patch, dumpmem.c is now shared by those and
pg_dumpall.  Seems the MSVC code previously could not handle that case,
which is fixed by this patch.

-- 
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + It's impossible for everything to be true. +