Horton

Re: [COMMITTERS] pgsql: Modify pg_dump to use error-free memory allocation macros. This

Bruce Momjian <bruce@momjian.us>

View thread
From: Bruce Momjian <bruce@momjian.us>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@postgresql.org
Date: 2011-11-27T03:38:04Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Modify pg_dump to use error-free memory allocation macros. This avoids

Attachments

Tom Lane wrote:
> Bruce Momjian <bruce@momjian.us> writes:
> > Basically, if we keep the existing functions in common.c, we are
> > deciding that it is never worth moving C functions to new C files for
> > source code clarity.  I was not sure we had made that decision in the
> > past.
> 
> I once held hope that git would let us be more flexible about this,
> but experimentation has shown that it's not significantly smarter than
> CVS about back-patches in moved code :-(.
> 
> I don't want to say that we should *never* move code once it's released;
> but I think the bar for that needs to be set pretty high, and this
> particular case isn't clearing the bar for me.

OK, hearing no other opinions, I have moved the functions back into
common.c, and created a new dumpmem.c/h.  Applied patch attached.

There is now no need to modify MSVC.

-- 
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + It's impossible for everything to be true. +