Horton

Re: FlexLocks

Bruce Momjian <bruce@momjian.us>

View thread
From: Bruce Momjian <bruce@momjian.us>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Kevin Grittner <Kevin.Grittner@wicourts.gov>, Simon Riggs <simon@2ndquadrant.com>, Alvaro Herrera <alvherre@commandprompt.com>, Pg Hackers <pgsql-hackers@postgresql.org>, Tom Lane <tgl@sss.pgh.pa.us>
Date: 2011-11-21T16:56:44Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Fix copyright notices, other minor editing in new range-types code.

Robert Haas wrote:
> On Wed, Nov 16, 2011 at 12:25 PM, Kevin Grittner
> <Kevin.Grittner@wicourts.gov> wrote:
> >> We could alternatively change one or the other of them to be a
> >> struct with one member, but I think the cure might be worse than
> >> the disease. ?By my count, we are talking about saving perhaps as
> >> many as 34 lines of code changes here, and that's only if
> >> complicating the type handling doesn't require any changes to
> >> places that are untouched at present, which I suspect it would.
> >
> > So I stepped through all the changes of this type, and I notice that
> > most of them are in areas where we've talked about likely benefits
> > of creating new FlexLock variants instead of staying with LWLocks;
> > if any of that is done (as seems likely), it further reduces the
> > impact from 34 lines. ?If we take care of LWLockHeldByMe() as you
> > describe, I'll concede the FlexLockId changes.
> 
> Updated patches attached.

It would be helpful if the patch included some text about how flexilocks
are different from ordinary lwlocks.

-- 
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + It's impossible for everything to be true. +