Re: const correctness
Bruce Momjian <bruce@momjian.us>
From: Bruce Momjian <bruce@momjian.us>
To: Kevin Grittner <Kevin.Grittner@wicourts.gov>
Cc: Peter Geoghegan <peter@2ndquadrant.com>, Peter Eisentraut <peter_e@gmx.net>, Thomas Munro <munro@ip9.org>, pgsql-hackers@postgresql.org, Tom Lane <tgl@sss.pgh.pa.us>
Date: 2011-11-10T21:40:32Z
Lists: pgsql-hackers
Kevin Grittner wrote: > Bruce Momjian <bruce@momjian.us> wrote: > > > I realize the patch only added 1-2 new const functions > > No, version 2 of the patch used the strchr() technique and has > *zero* new functions and *zero* new macros. Right. I was referring to the non-strchr() approach in the initial patch. > > but this is only a small area of the code being patched --- a full > > solution would have many more complex duplicates, and awkward > > changes as we add features. > > I'm not convinced of that, and I don't think it really has a bearing > on doing where it can be done with no new functions and no changes > to the code other than adding "const" to existing lines of code. Right, again I was referring to the non-strchr() approach, e.g. new functions. -- Bruce Momjian <bruce@momjian.us> http://momjian.us EnterpriseDB http://enterprisedb.com + It's impossible for everything to be true. +