Re: warning in pg_upgrade
Bruce Momjian <bruce@momjian.us>
From: Bruce Momjian <bruce@momjian.us>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Kevin Grittner <Kevin.Grittner@wicourts.gov>, pgsql-hackers@postgresql.org
Date: 2011-11-10T18:06:41Z
Lists: pgsql-hackers
Robert Haas wrote: > On Thu, Nov 3, 2011 at 3:45 PM, Kevin Grittner > <Kevin.Grittner@wicourts.gov> wrote: > > "Kevin Grittner" <Kevin.Grittner@wicourts.gov> wrote: > >> Untested patch attached for purposes of discussion. > > > > I got in a little testing on it -- not only does this patch > > eliminate the compile-time warning, but if you try to run pg_upgrade > > when another session has removed your current working directory, you > > get a reasonable message instead of the program attempting to > > proceed with undefined (potential garbage) for a working directory. > > Committed. Also fixed another compiler warning that popped up for me. Thanks Kevin and Robert. -- Bruce Momjian <bruce@momjian.us> http://momjian.us EnterpriseDB http://enterprisedb.com + It's impossible for everything to be true. +