Horton

Re: Online base backup from the hot-standby

Jun Ishiduka <ishizuka.jun@po.ntts.co.jp>

View thread
From: Jun Ishiduka <ishizuka.jun@po.ntts.co.jp>
To: masao.fujii@gmail.com
Cc: ssinger_pg@sympatico.ca, simon@2ndquadrant.com, pgsql-hackers@postgresql.org, magnus@hagander.net, robertmhaas@gmail.com, cedric.villemain.debian@gmail.com, heikki.linnakangas@enterprisedb.com
Date: 2011-10-13T05:01:38Z
Lists: pgsql-hackers 
Sorry.
I was not previously able to answer fujii's all comments.
This is the remaining answers.


> +	LWLockAcquire(WALInsertLock, LW_EXCLUSIVE);
> +	XLogCtl->Insert.fullPageWrites = fullPageWrites;
> +	LWLockRelease(WALInsertLock);
> 
> I don't think WALInsertLock needs to be hold here because there is no
> concurrently running process which can access Insert.fullPageWrites.
> For example, Insert->currpos and Insert->LogwrtResult are also changed
> without the lock there.
> 

Yes. 

> The source comment of XLogReportParameters() needs to be modified.

Yes, too.


--------------------------------------------
Jun Ishizuka
NTT Software Corporation
TEL：045-317-7018
E-Mail: ishizuka.jun@po.ntts.co.jp
--------------------------------------------