Thread

1. pg_upgrade exit_nicely()

   Peter Eisentraut <peter_e@gmx.net> — 2011-03-31T20:31:33Z

   While reading around in pg_upgrade code I came across the slightly
   bizarre function
   
   void exit_nicely(bool need_cleanup)
   
   The parameter doesn't actually determine whether any cleanup is done.
   The "cleanup" is done anyway and the parameter only controls the exit
   code in a backwards way.
   
   Also most of the cleanup appears to be useless, because you don't need
   to close files or free memory before the program exits.
   
   I figured this could be written more cleanly with an exit hook, so here
   is a patch.  I don't care much whether this patch is for now or later,
   just wanted to throw it out there.
   
   

2. Re: pg_upgrade exit_nicely()

   Bruce Momjian <bruce@momjian.us> — 2011-03-31T20:54:15Z

   Feel free to apply this to HEAD.
   
   ---------------------------------------------------------------------------
   
   Peter Eisentraut wrote:
   > While reading around in pg_upgrade code I came across the slightly
   > bizarre function
   > 
   > void exit_nicely(bool need_cleanup)
   > 
   > The parameter doesn't actually determine whether any cleanup is done.
   > The "cleanup" is done anyway and the parameter only controls the exit
   > code in a backwards way.
   > 
   > Also most of the cleanup appears to be useless, because you don't need
   > to close files or free memory before the program exits.
   > 
   > I figured this could be written more cleanly with an exit hook, so here
   > is a patch.  I don't care much whether this patch is for now or later,
   > just wanted to throw it out there.
   > 
   
   [ Attachment, skipping... ]
   
   > 
   > -- 
   > Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
   > To make changes to your subscription:
   > http://www.postgresql.org/mailpref/pgsql-hackers
   
   -- 
     Bruce Momjian  <bruce@momjian.us>        http://momjian.us
     EnterpriseDB                             http://enterprisedb.com
   
     + It's impossible for everything to be true. +